Fix login lockout: ensure zsh and linux-firmware are installed #17

Closed
jtadlock91 wants to merge 2 commits from fix/zsh-linux-firmware-lockout into master
jtadlock91 commented 2026-08-16 13:46:04 +00:00 (Migrated from github.com)

users.conf sets userShell: /bin/zsh globally, but zsh was never in any package list — this locks out every fresh install at first login regardless of which desktop is chosen. Also adds linux-firmware, missing entirely, which can leave GPU/wifi drivers uninitialized on first boot.

Verified via a full VM install + boot test.

users.conf sets userShell: /bin/zsh globally, but zsh was never in any package list — this locks out every fresh install at first login regardless of which desktop is chosen. Also adds linux-firmware, missing entirely, which can leave GPU/wifi drivers uninitialized on first boot. Verified via a full VM install + boot test.
c-ludenberg commented 2026-08-16 14:53:22 +00:00 (Migrated from github.com)

@jtadlock91 thanks for the PR ngl quick question did you test the live session or the actual installed system? profile.yaml rootfs doesn't affect installs, only the live env.

@jtadlock91 thanks for the PR ngl quick question did you test the live session or the actual installed system? profile.yaml rootfs doesn't affect installs, only the live env.
jtadlock91 commented 2026-08-16 16:56:32 +00:00 (Migrated from github.com)

Correction: the original profile.yaml fix doesn't actually work — profile.yaml only affects the live ISO session, never the installed target. Verified against the full 32-step Calamares install sequence in docs/installer.md. Moved the fix to basestrap.conf's operations list instead, which is the step guaranteed to run for every install regardless of desktop choice.

Correction: the original profile.yaml fix doesn't actually work — profile.yaml only affects the live ISO session, never the installed target. Verified against the full 32-step Calamares install sequence in docs/installer.md. Moved the fix to basestrap.conf's operations list instead, which is the step guaranteed to run for every install regardless of desktop choice.
c-ludenberg commented 2026-08-16 17:35:46 +00:00 (Migrated from github.com)

@jtadlock91 just a heads up: the live-overlay isnt the runtime config —
the real modules (netinstall.yaml, packagechooser etc) are in calamares-branding-antergos-next,
thats what the installer actually reads. and linux-firmware is already in netinstall.yaml's
Firmware group, optional by design. but yeah the zsh thing is a real bug — users.conf forces
/bin/zsh and nothing installs it. that belongs in netinstall.yaml Default group, not basestrap.

also the runtime netinstall.yaml ships in
calamares-branding-antergos-next (antergos-packages) — that's where zsh needs to
go in the Default group. open the PR there and i'll take it.
and i'll still credit you :)

@jtadlock91 just a heads up: the live-overlay isnt the runtime config — the real modules (netinstall.yaml, packagechooser etc) are in calamares-branding-antergos-next, thats what the installer actually reads. and linux-firmware is already in netinstall.yaml's Firmware group, optional by design. but yeah the zsh thing is a real bug — users.conf forces /bin/zsh and nothing installs it. that belongs in netinstall.yaml Default group, not basestrap. also the runtime netinstall.yaml ships in calamares-branding-antergos-next (antergos-packages) — that's where zsh needs to go in the Default group. open the PR there and i'll take it. and i'll still credit you :)
c-ludenberg commented 2026-08-16 19:14:02 +00:00 (Migrated from github.com)

@jtadlock91 closing this. the zsh lockout was a real find, thanks for catching it.
I landed the fix properly: zsh now goes into netinstall.yaml's Default group in the
calamares-branding-antergos-next package (that's the config the installer actually
reads), not the live-overlay. You're credited in the commit message.
The linux-firmware part was already handled — it's in the Firmware group, optional
by design. If you want, open the PR against Antergos-NeXT/antergos-packages next time
and it'll go straight through.

Also noting for next time: CONTRIBUTING.md requires GPG-signed commits (git commit -S)
this PR's commits aren't signed. Once that's set up, PRs against
Antergos-NeXT/antergos-packages will go straight through.

thanks for doing the PR tho

@jtadlock91 closing this. the zsh lockout was a real find, thanks for catching it. I landed the fix properly: zsh now goes into netinstall.yaml's Default group in the calamares-branding-antergos-next package (that's the config the installer actually reads), not the live-overlay. You're credited in the commit message. The linux-firmware part was already handled — it's in the Firmware group, optional by design. If you want, open the PR against Antergos-NeXT/antergos-packages next time and it'll go straight through. Also noting for next time: CONTRIBUTING.md requires GPG-signed commits (git commit -S) this PR's commits aren't signed. Once that's set up, PRs against Antergos-NeXT/antergos-packages will go straight through. thanks for doing the PR tho

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.